suneet-s commented on a change in pull request #9161: first/last aggregators
and nulls
URL: https://github.com/apache/druid/pull/9161#discussion_r368722885
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/first/DoubleFirstAggregatorFactory.java
##########
@@ -126,35 +158,54 @@ public AggregatorFactory getCombiningFactory()
return new DoubleFirstAggregatorFactory(name, name)
{
@Override
- public Aggregator factorize(ColumnSelectorFactory metricFactory,
ColumnValueSelector selector)
+ public Aggregator factorize(ColumnSelectorFactory metricFactory)
{
+ final ColumnValueSelector<SerializablePair<Long, Double>> selector =
Review comment:
Based on javadocs in `makeColumnValueSelector` this selector can be
`NilColumnValueSelector`
in which case `selector.getObject()` on line 170 would return null and line
171 would throw an NPE?
similar comment for the `factorizeBuffered` method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
