suneet-s commented on a change in pull request #9161: first/last aggregators and nulls URL: https://github.com/apache/druid/pull/9161#discussion_r368727641
########## File path: processing/src/test/java/org/apache/druid/query/aggregation/first/DoubleFirstAggregationTest.java ########## @@ -30,14 +30,16 @@ import org.apache.druid.query.aggregation.TestObjectColumnSelector; import org.apache.druid.segment.ColumnSelectorFactory; import org.apache.druid.segment.column.ColumnHolder; +import org.apache.druid.testing.InitializedNullHandlingTest; import org.easymock.EasyMock; import org.junit.Assert; import org.junit.Before; import org.junit.Test; import java.nio.ByteBuffer; +import java.util.Comparator; -public class DoubleFirstAggregationTest +public class DoubleFirstAggregationTest extends InitializedNullHandlingTest Review comment: it looks like these tests will only check `useDefaultValuesForNull = true` or is there some config I'm not seeing that sets it to `false` as well in another run? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
