suneet-s commented on a change in pull request #9161: first/last aggregators and nulls URL: https://github.com/apache/druid/pull/9161#discussion_r368717243
########## File path: processing/src/main/java/org/apache/druid/query/aggregation/first/DoubleFirstAggregator.java ########## @@ -20,42 +20,29 @@ package org.apache.druid.query.aggregation.first; import org.apache.druid.collections.SerializablePair; -import org.apache.druid.query.aggregation.Aggregator; import org.apache.druid.segment.BaseDoubleColumnValueSelector; import org.apache.druid.segment.BaseLongColumnValueSelector; -public class DoubleFirstAggregator implements Aggregator +public class DoubleFirstAggregator extends NumericFirstAggregator<BaseDoubleColumnValueSelector> Review comment: Nice abstraction! 🎉 note to self: can the get call be abstracted into the base class? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
