suneet-s commented on a change in pull request #9161: first/last aggregators 
and nulls
URL: https://github.com/apache/druid/pull/9161#discussion_r368713952
 
 

 ##########
 File path: docs/querying/aggregations.md
 ##########
 @@ -136,7 +136,7 @@ Note that queries with first/last aggregators on a segment 
created with rollup e
 
 #### `doubleFirst` aggregator
 
-`doubleFirst` computes the metric value with the minimum timestamp or 0 if no 
row exist
+`doubleFirst` computes the metric value with the minimum timestamp or 0 in 
default mode or `null` in SQL compatible mode if no row exist
 
 Review comment:
   Are you referring to this property - 
https://github.com/apache/druid/blob/master/docs/configuration/index.md#sql-compatible-null-handling
 ? Would be nice to link to the configuration here.
   
   nit: I'd re-phrase slightly
   
   ```
   computes the metric value with the minimum timestamp. If no row exists, it 
will return 0 or `null` if [SQL compatible 
mode](../configuration/index.md#sql-compatible-null-handling) is enabled
   ``` 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to