clintropolis commented on a change in pull request #9161: first/last
aggregators and nulls
URL: https://github.com/apache/druid/pull/9161#discussion_r368789089
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/first/DoubleFirstAggregatorFactory.java
##########
@@ -126,35 +158,54 @@ public AggregatorFactory getCombiningFactory()
return new DoubleFirstAggregatorFactory(name, name)
{
@Override
- public Aggregator factorize(ColumnSelectorFactory metricFactory,
ColumnValueSelector selector)
+ public Aggregator factorize(ColumnSelectorFactory metricFactory)
{
+ final ColumnValueSelector<SerializablePair<Long, Double>> selector =
Review comment:
Since this is for combining, the selector will be of the serialized pair
complex objects, which will not be null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
