clintropolis commented on a change in pull request #9161: first/last
aggregators and nulls
URL: https://github.com/apache/druid/pull/9161#discussion_r368789965
##########
File path:
core/src/main/java/org/apache/druid/collections/SerializablePair.java
##########
@@ -45,4 +46,25 @@ public T2 getRhs()
{
return rhs;
}
+
+ public static <T1, T2> Comparator<SerializablePair<T1, T2>>
createNullHandlingComparator(
Review comment:
This is covered by calcite query tests that order by the first/last
aggregators; afaik SerializedPair is only used by first/last despite it's
generic name, to store a timestamp and value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
