himanshug commented on a change in pull request #9507: optionally disable all
of hardcoded zookeeper use
URL: https://github.com/apache/druid/pull/9507#discussion_r397314006
##########
File path:
server/src/main/java/org/apache/druid/server/http/HistoricalResource.java
##########
@@ -50,14 +50,14 @@ public HistoricalResource(
@Produces(MediaType.APPLICATION_JSON)
public Response getLoadStatus()
{
- return Response.ok(ImmutableMap.of("cacheInitialized",
coordinator.isStarted())).build();
+ return Response.ok(ImmutableMap.of("cacheInitialized",
segmentLoadDropHandler.isStarted())).build();
}
@GET
@Path("/readiness")
public Response getReadiness()
{
- if (coordinator.isStarted()) {
+ if (segmentLoadDropHandler.isStarted()) {
Review comment:
primary thing checked by this endpoint is that historical startup
sequence has finished loading/announcing segments that it already had on
disk which is often a time consuming activity. that is still ensured by
`segmentLoadDropHandler.isStarted()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
