himanshug commented on a change in pull request #9507: optionally disable all
of hardcoded zookeeper use
URL: https://github.com/apache/druid/pull/9507#discussion_r397315538
##########
File path: server/src/main/java/org/apache/druid/curator/CuratorModule.java
##########
@@ -63,15 +63,20 @@
@Override
public void configure(Binder binder)
{
+ JsonConfigProvider.bind(binder, CURATOR_CONFIG_PREFIX,
ZkEnablementConfig.class);
JsonConfigProvider.bind(binder, CURATOR_CONFIG_PREFIX,
CuratorConfig.class);
JsonConfigProvider.bind(binder, EXHIBITOR_CONFIG_PREFIX,
ExhibitorConfig.class);
}
@Provides
@LazySingleton
@SuppressForbidden(reason = "System#err")
- public CuratorFramework makeCurator(CuratorConfig config, EnsembleProvider
ensembleProvider, Lifecycle lifecycle)
+ public CuratorFramework makeCurator(ZkEnablementConfig zkEnablementConfig,
CuratorConfig config, EnsembleProvider ensembleProvider, Lifecycle lifecycle)
Review comment:
Main reason for failing loudly here is so that if I forgot to disable zk in
some code path, then this method would immediately fail on node start with
guice injection errors leading to quick discovery of exactly what is missed.
this helped me catch quite a few places that I missed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
