capistrant commented on a change in pull request #10676:
URL: https://github.com/apache/druid/pull/10676#discussion_r601885386
##########
File path:
indexing-service/src/test/java/org/apache/druid/indexing/common/task/IndexTaskSerdeTest.java
##########
@@ -267,6 +272,7 @@ public void testBestEffortRollupWithHashedPartitionsSpec()
true,
10,
100,
+ null,
null
Review comment:
there was not any new explicit test written the other tests in that file
do use -1L and 1L as test values. I just updated another of the existing tests
to use 0L as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
