capistrant commented on a change in pull request #10676:
URL: https://github.com/apache/druid/pull/10676#discussion_r603491793
##########
File path:
indexing-service/src/test/java/org/apache/druid/indexing/common/task/CompactionTaskTest.java
##########
@@ -1447,6 +1452,7 @@ private void assertIngestionSchema(
null,
null,
null,
+ null,
null
Review comment:
> Given this discussion, can we add a guardrail that says if someone
tries to issue a compaction task when `awaitSegmentAvailabilityTimeoutMillis`
is non null and != 0 that this is not supported. I think that's the easiest way
forward to get the PR merged and it's a nice UX because it tells users that
what they are doing is untested. Similar comment for auto-compaction (and other
ingestion tasks that I may have missed)
Are you expecting a job submit failure then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
