capistrant commented on a change in pull request #10676:
URL: https://github.com/apache/druid/pull/10676#discussion_r601980096
##########
File path:
indexing-service/src/test/java/org/apache/druid/indexing/common/task/CompactionTaskTest.java
##########
@@ -1447,6 +1452,7 @@ private void assertIngestionSchema(
null,
null,
null,
+ null,
null
Review comment:
@jihoonson when it comes to judging segment handoff, isn't a compaction
task a parallel indexing task under the hood? I just tested a compaction task
submit with tuning config and the new config for handoff set to 5 minutes. The
task ran and logs indicate it confirmed handoff of newly created compacted
segment.
Should not allow the handoff to occur when it is a compact type task? I'm
not sure how we would do that, since the TuningConfig is not modifiable as
written and if the task(s) ran by the compact task are just parallel indexing
tasks, I'm not sure how we would tell them not to honor the handoff wait config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
