zachjsh commented on code in PR #13360:
URL: https://github.com/apache/druid/pull/13360#discussion_r1029778992
##########
server/src/main/java/org/apache/druid/catalog/model/table/ExternalTableDefn.java:
##########
@@ -99,6 +98,8 @@ private static List<PropertyDefn<?>> addFormatProperties(
)
{
List<PropertyDefn<?>> toAdd = new ArrayList<>();
+ PropertyDefn<?> formatProp = new
ModelProperties.StringPropertyDefn(FORMAT_PROPERTY,
PropertyAttributes.SQL_FN_PARAM);
Review Comment:
question: Is this property key being set with a value here? It appears no. I
assume that the user must supply a value for this property based on other
checks made in this class. Where is the value for this property set? And if not
set, explicitly by the user, could this property creation here with no value
interfere with validation checks, and cause an external table that a user hasnt
given a format property value for to be seen as being valid because of the
existence of the property but with no value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
