zachjsh commented on code in PR #13360:
URL: https://github.com/apache/druid/pull/13360#discussion_r1029804438
##########
server/src/main/java/org/apache/druid/catalog/model/table/InputFormats.java:
##########
@@ -127,8 +130,8 @@ public FlatTextFormatDefn(
typeTag,
CatalogUtils.concatLists(
Arrays.asList(
- new StringPropertyDefn(LIST_DELIMITER_PROPERTY),
- new IntPropertyDefn(SKIP_ROWS_PROPERTY)
+ new StringPropertyDefn(LIST_DELIMITER_PROPERTY,
PropertyAttributes.OPTIONAL_SQL_FN_PARAM),
Review Comment:
Question: What are the default values of these properties if not given, and
where are the defaults defined?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
