zachjsh commented on code in PR #13360:
URL: https://github.com/apache/druid/pull/13360#discussion_r1029784356
##########
server/src/main/java/org/apache/druid/catalog/model/table/ExternalTableSpec.java:
##########
@@ -24,15 +24,16 @@
import org.apache.druid.segment.column.RowSignature;
/**
- * Catalog form of an external table specification used to
- * pass along the three components needed for an external table
- * in MSQ ingest.
+ * Catalog form of an external table specification used to pass along the three
+ * components needed for an external table in MSQ ingest. Just like
+ * {@code ExternalTableSource}, except that the parameters are not required
+ * to be non-null.
*/
public class ExternalTableSpec
{
- protected final InputSource inputSource;
- protected final InputFormat inputFormat;
- protected final RowSignature signature;
+ public final InputSource inputSource;
Review Comment:
given javadoc, think would be good to add `@Nullable` to these
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
