zachjsh commented on code in PR #13360:
URL: https://github.com/apache/druid/pull/13360#discussion_r1029807202
##########
server/src/main/java/org/apache/druid/catalog/model/table/InputFormats.java:
##########
@@ -262,13 +265,37 @@ public static class GenericFormatDefn extends
BaseFormatDefn
public static final String INPUT_FORMAT_SPEC_PROPERTY = "inputFormatSpec";
public static final String FORMAT_KEY = "generic";
+ private static class FormatPropertyDefn extends
SimplePropertyDefn<InputFormat>
+ {
+ public FormatPropertyDefn()
+ {
+ super(
+ INPUT_FORMAT_SPEC_PROPERTY,
+ InputFormat.class,
+ PropertyAttributes.merge(
+ ImmutableMap.of(
+ PropertyAttributes.SQL_JAVA_TYPE,
+ String.class
+ ),
+ PropertyAttributes.OPTIONAL_SQL_FN_PARAM
Review Comment:
Why is this property optional, I thought it would be required; seems that it
defines this format?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
