zachjsh commented on code in PR #13360: URL: https://github.com/apache/druid/pull/13360#discussion_r1030012741
########## sql/src/main/java/org/apache/druid/sql/calcite/external/FunctionParameterImpl.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.sql.calcite.external; + +import org.apache.calcite.rel.type.RelDataType; +import org.apache.calcite.rel.type.RelDataTypeFactory; +import org.apache.calcite.schema.FunctionParameter; + +public class FunctionParameterImpl implements FunctionParameter +{ + private final int ordinal; + private final String name; + private final RelDataType type; + private final boolean isOptional; + + public FunctionParameterImpl(int ordinal, String name, RelDataType type, boolean isOptional) + { + this.ordinal = ordinal; + this.name = name; + this.type = type; + this.isOptional = isOptional; + } + + public FunctionParameterImpl(int ordinal, String name, RelDataType type) + { + this(ordinal, name, type, false); + } + + @Override + public int getOrdinal() + { + return ordinal; + } + + @Override + public String getName() + { + return name; + } + + @Override + public RelDataType getType(RelDataTypeFactory typeFactory) + { + return type; + } + + @Override + public boolean isOptional() + { + return isOptional; + } + + @Override + public String toString() + { + return "FunctionParameter{" + + "name=\"" + name + "\"" + + ", type=" + type + + ", optional=" + isOptional + Review Comment: nit: should we include ordinal too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
