zachjsh commented on code in PR #13360:
URL: https://github.com/apache/druid/pull/13360#discussion_r1029787453
##########
server/src/main/java/org/apache/druid/catalog/model/table/HttpTableDefn.java:
##########
@@ -65,39 +66,38 @@ public class HttpTableDefn extends
FormattedExternalTableDefn implements Paramet
// that class for the meaning of these properties.
public static final String URI_TEMPLATE_PROPERTY = "uriTemplate";
- public static final String USER_PROPERTY = "user";
+
+ // Note, cannot be the simpler "user" since USER is a reserved word in SQL
+ // and we don't want to require users to quote "user" each time it is used.
+ public static final String USER_PROPERTY = "userName";
public static final String PASSWORD_PROPERTY = "password";
public static final String PASSWORD_ENV_VAR_PROPERTY = "passwordEnvVar";
public static final String URIS_PROPERTY = "uris";
- public static final String URIS_PARAMETER = "uris";
public HttpTableDefn()
{
super(
"HTTP input table",
TABLE_TYPE,
Arrays.asList(
- new StringListPropertyDefn(URIS_PROPERTY),
- new StringPropertyDefn(USER_PROPERTY),
- new StringPropertyDefn(PASSWORD_PROPERTY),
- new StringPropertyDefn(PASSWORD_ENV_VAR_PROPERTY),
- new StringPropertyDefn(URI_TEMPLATE_PROPERTY)
+ new StringListPropertyDefn(URIS_PROPERTY,
PropertyAttributes.SQL_AND_TABLE_PARAM),
+ new StringPropertyDefn(USER_PROPERTY,
PropertyAttributes.OPTIONAL_SQL_FN_PARAM),
+ new StringPropertyDefn(PASSWORD_PROPERTY,
PropertyAttributes.OPTIONAL_SQL_FN_PARAM),
+ new StringPropertyDefn(PASSWORD_ENV_VAR_PROPERTY,
PropertyAttributes.OPTIONAL_SQL_FN_PARAM),
+ new StringPropertyDefn(URI_TEMPLATE_PROPERTY, null)
Review Comment:
why does this parameter not have any attributes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
