georgew5656 commented on code in PR #14771:
URL: https://github.com/apache/druid/pull/14771#discussion_r1293781239
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/KubernetesPeonClient.java:
##########
@@ -42,12 +48,22 @@ public class KubernetesPeonClient
private final KubernetesClientApi clientApi;
private final String namespace;
private final boolean debugJobs;
+ private final TaskAdapter adapter;
+ private final ServiceEmitter emitter;
- public KubernetesPeonClient(KubernetesClientApi clientApi, String namespace,
boolean debugJobs)
+ public KubernetesPeonClient(
+ KubernetesClientApi clientApi,
+ String namespace,
+ boolean debugJobs,
+ TaskAdapter adapter,
+ ServiceEmitter emitter
+ )
{
this.clientApi = clientApi;
this.namespace = namespace;
this.debugJobs = debugJobs;
+ this.adapter = adapter;
+ this.emitter = emitter;
}
public Pod launchPeonJobAndWaitForStart(Job job, long howLong, TimeUnit
timeUnit)
Review Comment:
i am also hoping to deprecate toTask(Job) in this pr:
https://github.com/apache/druid/pull/14802/files to allow us to pull tasks
instead of storing them as a env variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
