YongGang commented on code in PR #14771: URL: https://github.com/apache/druid/pull/14771#discussion_r1293835077
########## extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunner.java: ########## @@ -106,7 +106,7 @@ public class KubernetesTaskRunner implements TaskLogStreamer, TaskRunner private final HttpClient httpClient; private final PeonLifecycleFactory peonLifecycleFactory; private final ServiceEmitter emitter; - + private static String WORKER_CATEGORY = "_k8s_worker_category"; Review Comment: Yup, we can use this `WORKER_CATEGORY` as the naming convention is more aligned with other places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
