YongGang commented on code in PR #14771:
URL: https://github.com/apache/druid/pull/14771#discussion_r1293891029
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/KubernetesPeonClient.java:
##########
@@ -69,12 +85,14 @@ public Pod launchPeonJobAndWaitForStart(Job job, long
howLong, TimeUnit timeUnit
}, howLong, timeUnit);
long duration = System.currentTimeMillis() - start;
log.info("Took task %s %d ms for pod to startup", jobName, duration);
+ emitK8sPodMetrics(job, "peon/startup/time", duration);
Review Comment:
I like the idea of prefix with k8s, will do that. But I saw other metrics
are not end with unit such as `task/run/time` wonder whether we should align
with the existing ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
