github-code-scanning[bot] commented on code in PR #14771:
URL: https://github.com/apache/druid/pull/14771#discussion_r1293994977
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunnerFactory.java:
##########
@@ -70,6 +70,7 @@
TaskConfig taskConfig,
Properties properties,
DruidKubernetesClient druidKubernetesClient,
+ TaskAdapter adapter,
Review Comment:
## Useless parameter
The parameter 'adapter' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5674)
##########
extensions-contrib/kubernetes-overlord-extensions/src/test/java/org/apache/druid/k8s/overlord/taskadapter/DruidPeonClientIntegrationTest.java:
##########
@@ -90,7 +92,29 @@
new NamedType(IndexTask.IndexTuningConfig.class, "index")
);
k8sClient = new DruidKubernetesClient();
- peonClient = new KubernetesPeonClient(k8sClient, "default", false);
+ ServiceEmitter serviceEmitter = new ServiceEmitter("service", "host", null)
+ {
+ @Override
+ public void emit(Event event)
+ {
+ }
+ };
+ Task task = K8sTestUtils.getTask();
+ TaskAdapter adapter = new TaskAdapter()
+ {
+ @Override
+ public Job fromTask(Task task)
+ {
+ return null;
+ }
+
+ @Override
+ public Task toTask(Job from)
+ {
+ return task;
+ }
+ };
Review Comment:
## Unread local variable
Variable 'TaskAdapter adapter' is never read.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5675)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
