YongGang commented on PR #14771: URL: https://github.com/apache/druid/pull/14771#issuecomment-1678170060
> Request changes because: > > * The worker categories are inconsistent across the metrics reported from the k8sTaskRunner > * I do not think idle tasks should report a negative number as none of the other task runners do something like this. If we want to show the number of tasks that are not running, but should be, I think we need a new metric because a task can be added to the tasks map in Druid, but not yet started because of many reasons and it would be good to have visibility into that. > * Please add docs for the new metrics in `docs/development/extensions-contrib/k8s-jobs.md` Thanks for the review, I think I addressed all of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
