suneet-s commented on code in PR #14771:
URL: https://github.com/apache/druid/pull/14771#discussion_r1295122826
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunner.java:
##########
@@ -370,13 +370,13 @@ public Optional<ScalingStats> getScalingStats()
@Override
public Map<String, Long> getIdleTaskSlotCount()
{
- return Collections.emptyMap();
+ return ImmutableMap.of(WORKER_CATEGORY, Long.valueOf(config.getCapacity()
- tasks.size()));
Review Comment:
For the K8sTaskRunner, the metric should track the number of pods that are
in the `waitUntilCondition` in `launchPeonJobAndWaitForStart`. That is what I
believe is the equivalent of a pending task with the K8sTaskRunner.
https://github.com/apache/druid/blob/8fa78594ea66b5508eb238c3d5f58d1cb973c7a9/extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/KubernetesPeonClient.java#L64-L69
We could also add a dimension to report if the pod timed out waiting to
start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
