clintropolis commented on PR #14695: URL: https://github.com/apache/druid/pull/14695#issuecomment-1680118459
>For DruidCoordinatorConfig, I think the following structure should work: > ... That seems pretty reasonable to me, since we are switching to JSON config, and a ton of those configs have a `period` and `durationToRetain`, it feels like there is some common class that should be able to be re-used for most of those configs. >druid.coordinator.curator.loadqueuepeon.numCallbackThreads Curator loading is already deprecated and will be removed before the next release. We can remove this config and hardcode the only usage in CliCoordinator to 2 for the time being. If for some reason we don't get this removed prior to the next release, we should probably fix it to be consistent with the http load queue peon config, and make its path be `druid.coordinator.loadqueuepeon.curator.numCallbackThreads` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
