clintropolis commented on code in PR #14695:
URL: https://github.com/apache/druid/pull/14695#discussion_r1295493542
##########
processing/src/main/java/org/apache/druid/java/util/metrics/DruidMonitorSchedulerConfig.java:
##########
@@ -46,7 +45,6 @@ public Period getEmissionPeriod()
return emissionPeriod;
}
- @Override
public Duration getEmitterPeriod()
Review Comment:
renamed, though the other method wasn't actually used which became apparent
after removing the json annotation, so i removed it too
##########
processing/src/main/java/org/apache/druid/query/DruidProcessingConfig.java:
##########
@@ -19,45 +19,85 @@
package org.apache.druid.query;
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.google.common.annotations.VisibleForTesting;
import org.apache.druid.java.util.common.HumanReadableBytes;
import org.apache.druid.java.util.common.IAE;
-import org.apache.druid.java.util.common.concurrent.ExecutorServiceConfig;
-import org.apache.druid.java.util.common.guava.ParallelMergeCombiningSequence;
import org.apache.druid.java.util.common.logger.Logger;
import org.apache.druid.segment.column.ColumnConfig;
import org.apache.druid.utils.JvmUtils;
-import org.skife.config.Config;
+import javax.annotation.Nullable;
import java.util.concurrent.atomic.AtomicReference;
-public abstract class DruidProcessingConfig extends ExecutorServiceConfig
implements ColumnConfig
+public class DruidProcessingConfig implements ColumnConfig
{
private static final Logger log = new Logger(DruidProcessingConfig.class);
- public static final int DEFAULT_NUM_MERGE_BUFFERS = -1;
- public static final HumanReadableBytes DEFAULT_PROCESSING_BUFFER_SIZE_BYTES
= HumanReadableBytes.valueOf(-1);
- public static final int MAX_DEFAULT_PROCESSING_BUFFER_SIZE_BYTES = 1024 *
1024 * 1024;
- public static final int DEFAULT_MERGE_POOL_AWAIT_SHUTDOWN_MILLIS = 60_000;
- public static final int DEFAULT_INITIAL_BUFFERS_FOR_INTERMEDIATE_POOL = 0;
-
- private AtomicReference<Integer> computedBufferSizeBytes = new
AtomicReference<>();
-
- @Config({"druid.computation.buffer.size", "${base_path}.buffer.sizeBytes"})
- public HumanReadableBytes intermediateComputeSizeBytesConfigured()
+ public static long computeMaxMemoryFromMaxHeapSize()
Review Comment:
inlined
##########
server/src/main/java/org/apache/druid/guice/LegacyBrokerParallelMergeConfigModule.java:
##########
@@ -19,17 +19,17 @@
package org.apache.druid.guice;
-import com.google.common.collect.ImmutableMap;
import com.google.inject.Binder;
import com.google.inject.Module;
-import org.apache.druid.query.DruidProcessingConfig;
+import org.apache.druid.query.LegacyBrokerParallelMergeConfig;
-public class DruidProcessingConfigModule implements Module
+@Deprecated
+public class LegacyBrokerParallelMergeConfigModule implements Module
Review Comment:
added javadoc here and to the associated config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
