clintropolis commented on code in PR #14695:
URL: https://github.com/apache/druid/pull/14695#discussion_r1295495176
##########
server/src/main/java/org/apache/druid/guice/RouterProcessingModule.java:
##########
@@ -53,16 +53,17 @@ public class RouterProcessingModule implements Module
@Override
public void configure(Binder binder)
{
- binder.bind(ExecutorServiceConfig.class).to(DruidProcessingConfig.class);
+ JsonConfigProvider.bind(binder, "druid.processing",
DruidProcessingConfig.class);
+ binder.bind(ColumnConfig.class).to(DruidProcessingConfig.class);
MetricsModule.register(binder, ExecutorServiceMonitor.class);
}
@Provides
@ManageLifecycle
public QueryProcessingPool getProcessingExecutorPool(DruidProcessingConfig
config)
{
- if (config.getNumThreadsConfigured() !=
ExecutorServiceConfig.DEFAULT_NUM_THREADS) {
- log.error("numThreads[%d] configured, that is ignored on Router",
config.getNumThreadsConfigured());
+ if (config.isNumThreadsConfigured()) {
+ log.error("numThreads[%d] configured, that is ignored on Router",
config.getNumThreads());
Review Comment:
changed to warn, iirc the idea was that these configs have no effect on
router so logging about it makes it obvious that a config change didn't
actually change anything. I don't really feel strongly either way, though i do
see some merit to getting feedback when a config is specified that has no
effect, however we aren't doing it very consistently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
