kfaraz commented on PR #14695:
URL: https://github.com/apache/druid/pull/14695#issuecomment-1676829173
For `DruidCoordinatorConfig`, I think the following structure should work:
Existing class `DruidCoordinatorConfig` bound to `druid.coordinator`
- `startDelay`
- `period`
- `kill`: new class `CoordinatorKillConfigs`
- `unused`: new class `KillUnusedSegmentsConfig`
- `period`
- `durationToRetain`
- `ignoreDurationToRetain`
- `maxSegments`
- `supervisor`: new class `MetadataCleanupConfig` for this and other
cleanups below
- `period`
- `durationToRetain`
- `audit`
- `period`
- `durationToRetain`
- `datasource`
- `period`
- `durationToRetain`
- `rule`
- `period`
- `durationToRetain`
- `compaction`
- `period`
- `loadqueuepeon`: new class `LoadQueuePeonConfig`
- `type`
- `loadTimeout` (replacing `druid.coordinator.load.timeout`)
- `http`: new class `HttpLoadQueuePeonConfig`
- `batchSize`
- `repeatDelay`
- `hostTimeout`
Deprecated paths:
new class `LegacyKillUnusedSegmentsConfig` which has the following paths
- `druid.coordinator.kill.period`
- `druid.coordinator.kill.durationToRetain`
- `druid.coordinator.kill.ignoreDurationToRetain`
- `druid.coordinator.kill.maxSegments`
Removed paths:
- `druid.coordinator.curator.loadqueuepeon.numCallbackThreads`
Curator loading is already deprecated and will be removed before the next
release. We can remove this config and hardcode the only usage in
`CliCoordinator` to 2 for the time being.
- `druid.coordinator.load.timeout`
This can be replaced by `druid.coordinator.loadqueuepeon.loadTimeout`. The
older config can just be dropped as I have never seen any cluster configure
this value to anything other than the default (15 minutes). Also, I have other
changes planned for this area which are going to further refine this config.
---
@clintropolis , let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
