clintropolis opened a new pull request, #14695: URL: https://github.com/apache/druid/pull/14695
### Description This PR aims to deprecate usage of config-magic (`ConfigProvider`) in favor of using `JsonConfigProvider` everywhere. In the process I have made the config paths a bit more sane (one of the reasons to replace `ConfigProvider` is because of how easily devs can make paths that don't make much structural sense due to the free-form nature of how config paths are defined). The main users are `DruidProcessingConfig` and `DruidCoordinatorConfig`, which have been reworked to be simple jackson annotated objects which are injected with a fallback to support legacy config-magic paths as needed. After these changes are released, we can consider finally deleting config-magic in a future release. For `DruidProcessingConfig`, the structure was mostly ok, but I have flattened the broker parallel merge config into just living at `druid.processing.merge` (i guess we could change this, i don't feel very strongly), and split it into a totally separate config from the rest of `DruidProcessingConfig` since it is only used by brokers for `CachingClusteredClient`. For `DruidCoordinatorConfig` WIP (i haven't done anything to it yet, but it definitely needs reworked...) #### Release note Broker parallel merge config options at paths `druid.processing.merge.pool.*` and `druid.processing.merge.task.*` have been flattened to use the `druid.processing.merge` prefix. Note that the legacy paths will still function, but will issue a warning log noting that these configs have been deprecated and will be removed in a future release, along with the new paths which should be used to continue configuring these values. WIP <hr> This PR has: - [ ] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
