clintropolis commented on code in PR #14695:
URL: https://github.com/apache/druid/pull/14695#discussion_r1295491942
##########
processing/src/main/java/org/apache/druid/java/util/metrics/DruidMonitorSchedulerConfig.java:
##########
@@ -17,24 +17,23 @@
* under the License.
*/
-package org.apache.druid.server.metrics;
+package org.apache.druid.java.util.metrics;
import com.fasterxml.jackson.annotation.JsonProperty;
-import org.apache.druid.java.util.metrics.BasicMonitorScheduler;
-import org.apache.druid.java.util.metrics.MonitorSchedulerConfig;
import org.joda.time.Duration;
import org.joda.time.Period;
/**
*/
-public class DruidMonitorSchedulerConfig extends MonitorSchedulerConfig
+public class DruidMonitorSchedulerConfig
{
@JsonProperty
private String schedulerClassName = BasicMonitorScheduler.class.getName();
@JsonProperty
private Period emissionPeriod = new Period("PT1M");
+ @JsonProperty
public String getSchedulerClassName()
Review Comment:
they don't currently get serialized so its not really necessary, not sure
why some of the getters here had them, removed them all to make consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
