clintropolis commented on code in PR #15058:
URL: https://github.com/apache/druid/pull/15058#discussion_r1346765689
##########
processing/src/main/java/org/apache/druid/query/filter/vector/ArrayVectorValueMatcher.java:
##########
@@ -78,7 +77,9 @@ public ReadableVectorMatch match(final ReadableVectorMatch
mask)
for (int i = 0; i < mask.getSelectionSize(); i++) {
final int rowNum = mask.getSelection()[i];
Object o = vector[rowNum];
- if (o == null || o instanceof Object[]) {
+ if (includeUnknown && o == null &&
predicateFactory.isNullInputUnknown()) {
+ selection[numRows++] = rowNum;
+ } else if (o == null || o instanceof Object[]) {
Review Comment:
btw, updated the javadocs on isNullInputUnknown of the predicate factory to
hopefully clear this up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
