abhishekrb19 commented on code in PR #16324:
URL: https://github.com/apache/druid/pull/16324#discussion_r1577256445
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/CompactionTaskTest.java:
##########
@@ -1512,7 +1512,7 @@ public void
testQueryGranularityAndNullSegmentGranularity() throws IOException
AGGREGATORS.stream().map(AggregatorFactory::getCombiningFactory).collect(Collectors.toList()),
SEGMENT_INTERVALS,
Granularities.MONTH,
- new PeriodGranularity(Period.months(3), null, null),
Review Comment:
hmm, I wonder what it meant previously when query granularity was 3 months,
while the segment granularity was 1 month? Was this an oversight not handled in
this test and/or code :
https://github.com/apache/druid/blob/master/indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java#L657-L660
Thinking out loud if this would break any existing compaction tasks when
segment granularity is unspecified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
