AmatyaAvadhanula commented on code in PR #16324:
URL: https://github.com/apache/druid/pull/16324#discussion_r1577307196
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/CompactionTaskTest.java:
##########
@@ -1512,7 +1512,7 @@ public void
testQueryGranularityAndNullSegmentGranularity() throws IOException
AGGREGATORS.stream().map(AggregatorFactory::getCombiningFactory).collect(Collectors.toList()),
SEGMENT_INTERVALS,
Granularities.MONTH,
- new PeriodGranularity(Period.months(3), null, null),
Review Comment:
Yes, it could break existing compaction configurations.
My observation is that for replacing jobs such as compaction, if we specify
a coarser query granularity like ALL and segment granularity as DAY,
1. We process the data as if the segment granularity and query granularity
were both DAY.
2. The segment metadata retains query granularity as ALL and segment
granularity as DAY.
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/CompactionTaskTest.java:
##########
@@ -1492,7 +1492,7 @@ public void
testQueryGranularityAndNullSegmentGranularity() throws IOException
null,
null,
null,
- new ClientCompactionTaskGranularitySpec(null, new
PeriodGranularity(Period.months(3), null, null), null),
+ new ClientCompactionTaskGranularitySpec(null, Granularities.HOUR,
null),
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
