marta-jankovics commented on code in PR #3351:
URL: https://github.com/apache/fineract/pull/3351#discussion_r1282484939
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/data/SavingsAccountTransactionData.java:
##########
@@ -782,7 +783,8 @@ public static SavingsAccountTransactionData
withWithDrawalTransactionDetails(
savingsAccountTransactionData.runningBalance,
savingsAccountTransactionData.reversed,
savingsAccountTransactionData.transfer,
savingsAccountTransactionData.paymentTypeOptions,
savingsAccountTransactionData.interestedPostedAsOn,
savingsAccountTransactionData.submittedByUsername,
- savingsAccountTransactionData.note,
savingsAccountTransactionData.lienTransaction);
+ savingsAccountTransactionData.note,
savingsAccountTransactionData.lienTransaction,
+ savingsAccountTransactionData.getSubmittedOnDate());
Review Comment:
I agree with you that having the same pattern for all the parameters would
be the best. But it is not a good pattern to call the fields directly, so I am
not convinced that it is better, to follow a wrong pattern than break it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
