marta-jankovics commented on code in PR #3351:
URL: https://github.com/apache/fineract/pull/3351#discussion_r1282969834
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/data/SavingsAccountTransactionData.java:
##########
@@ -117,7 +117,7 @@ public static SavingsAccountTransactionData
interestPosting(final SavingsAccount
savingsAccountTransactionType.getValue().longValue(),
savingsAccountTransactionType.getCode(),
savingsAccountTransactionType.getValue().toString());
return new SavingsAccountTransactionData(amount.getAmount(), date,
savingsAccount.getId(), savingsAccountTransactionEnumData,
- isReversed, null, isManualTransaction, lienTransaction);
+ isReversed, null, isManualTransaction, lienTransaction, date);
Review Comment:
The job which run on business date 1st Aug will pick the interest postings
due on 1st Aug independently on which day it is running actually. So both the
transaction date and the submittedOnDate will be the same.
The problem with SavingsAccountTransactionData is that it is used for many
purposes (internal transfer object, template description, get API response) and
so the submittedOnDate can not be left empty where it was set before. Eg. for
interest posting it will be mapped directly to insert query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
