marta-jankovics commented on code in PR #3351:
URL: https://github.com/apache/fineract/pull/3351#discussion_r1283111331
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/data/SavingsAccountTransactionData.java:
##########
@@ -117,7 +117,7 @@ public static SavingsAccountTransactionData
interestPosting(final SavingsAccount
savingsAccountTransactionType.getValue().longValue(),
savingsAccountTransactionType.getCode(),
savingsAccountTransactionType.getValue().toString());
return new SavingsAccountTransactionData(amount.getAmount(), date,
savingsAccount.getId(), savingsAccountTransactionEnumData,
- isReversed, null, isManualTransaction, lienTransaction);
+ isReversed, null, isManualTransaction, lienTransaction, date);
Review Comment:
Sometimes this data is a template that is shown on the UI (eg. representing
future interest postings), that case the submittedOnDate would be better to
keep null, because it was not submitted yet... but it is hard to differentiate
when it is used for what... so better would be clean this up and use different
data types, but we did not want to make a bigger refactor...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
