marta-jankovics commented on code in PR #3351:
URL: https://github.com/apache/fineract/pull/3351#discussion_r1283098649
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/data/SavingsAccountTransactionData.java:
##########
@@ -117,7 +117,7 @@ public static SavingsAccountTransactionData
interestPosting(final SavingsAccount
savingsAccountTransactionType.getValue().longValue(),
savingsAccountTransactionType.getCode(),
savingsAccountTransactionType.getValue().toString());
return new SavingsAccountTransactionData(amount.getAmount(), date,
savingsAccount.getId(), savingsAccountTransactionEnumData,
- isReversed, null, isManualTransaction, lienTransaction);
+ isReversed, null, isManualTransaction, lienTransaction, date);
Review Comment:
AFAIK the job picks the same day interest dues, so your example would not
happen. But if there is no business date set, then it can happen that the job
runs days later and still posts interest from the past and in this case you are
right that the submittedOnDate should not be set to the transaction date.
@Mk9894 please change posting submitted dates to getBusinessDate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
