Mk9894 commented on code in PR #3351:
URL: https://github.com/apache/fineract/pull/3351#discussion_r1282991057
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/data/SavingsAccountTransactionData.java:
##########
@@ -782,7 +783,8 @@ public static SavingsAccountTransactionData
withWithDrawalTransactionDetails(
savingsAccountTransactionData.runningBalance,
savingsAccountTransactionData.reversed,
savingsAccountTransactionData.transfer,
savingsAccountTransactionData.paymentTypeOptions,
savingsAccountTransactionData.interestedPostedAsOn,
savingsAccountTransactionData.submittedByUsername,
- savingsAccountTransactionData.note,
savingsAccountTransactionData.lienTransaction);
+ savingsAccountTransactionData.note,
savingsAccountTransactionData.lienTransaction,
+ savingsAccountTransactionData.getSubmittedOnDate());
Review Comment:
I think we can modify all other fields to use the getter, which would be the
better way to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
