adamsaghy commented on code in PR #3351:
URL: https://github.com/apache/fineract/pull/3351#discussion_r1282972992
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/data/SavingsAccountTransactionData.java:
##########
@@ -117,7 +117,7 @@ public static SavingsAccountTransactionData
interestPosting(final SavingsAccount
savingsAccountTransactionType.getValue().longValue(),
savingsAccountTransactionType.getCode(),
savingsAccountTransactionType.getValue().toString());
return new SavingsAccountTransactionData(amount.getAmount(), date,
savingsAccount.getId(), savingsAccountTransactionEnumData,
- isReversed, null, isManualTransaction, lienTransaction);
+ isReversed, null, isManualTransaction, lienTransaction, date);
Review Comment:
i dont think it should be left empty. it should be set the actual business
date. However in the above example the transaction date and submitted on date
cannot be the same. So i dont think we should set the submitted on date based
on the transaction date.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
