adamsaghy commented on code in PR #3545:
URL: https://github.com/apache/fineract/pull/3545#discussion_r1374640268


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/api/ChargesApiResourceSwagger.java:
##########
@@ -188,7 +188,7 @@ static final class 
GetChargesTemplateLoanChargeCalculationTypeOptions {
             private GetChargesTemplateLoanChargeCalculationTypeOptions() {}
 
             @Schema(example = "1")
-            public Long id;
+            public Integer id;

Review Comment:
   This looks wrong to me...It should be Long based on the EnumOptionData 
line:36



##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/api/ChargesApiResourceSwagger.java:
##########
@@ -200,7 +200,7 @@ static final class 
GetChargesTemplateLoanChargeTimeTypeOptions {
             private GetChargesTemplateLoanChargeTimeTypeOptions() {}
 
             @Schema(example = "2")
-            public Long id;

Review Comment:
   This looks wrong to me...It should be Long based on the EnumOptionData 
line:36



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to