linguini1 commented on PR #17363: URL: https://github.com/apache/nuttx/pull/17363#issuecomment-3576655194
The reason I'm not explicitly approving this PR is because I still hold the belief that there does not need to be two different interfaces. I don't think we should merge both just to remove the legacy version later. The "uORB" version, as raiden pointed out, does not actually need uORB to work and can be used as a character driver in the unified sensor framework anyways. I don't think there's a justification to merge both just because of int vs float performance, in my opinion. We can fix that at a framework level with fixed point math (sooner rather than later would be good, I might take a look at it). TLDR; while I think the "uORB" portion of this PR looks fine, even if this base.c approach is taken by other drivers, I do not think we should merge the legacy interface because it creates more maintenance work especially if we're just going to remove it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
