acassis commented on PR #17363: URL: https://github.com/apache/nuttx/pull/17363#issuecomment-3575500501
@linguini1 since we don't have a definition how to use uORB sensor drivers only as char dev driver (not fixed point implementation, no CONFIG_SENSOR_UORB to disable not needed parts of the driver), I suggest merging it. Other drivers also implement the base.c idea, normally it is done to isolate I2C, SPI specific functions from the logic driver (please look drivers/sensors/bmi088* for reference). I think the only drawback here is because he didn't implemented the SPI support, but not a big issue. We will need to remove the legacy drivers in the future, so I don't see an issue remove the char device driver from this PR in the future. At least now we will have it available for anyone willing to test/use this sensor. Just my 2 cents! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
