xiaoxiang781216 commented on code in PR #3840:
URL: https://github.com/apache/nuttx-apps/pull/3840#discussion_r4272069260
##########
include/system/nxplayer.h:
##########
@@ -40,12 +41,17 @@
* Public Type Declarations
****************************************************************************/
+struct nxplayer_s;
+
struct nxplayer_dec_ops_s
{
int format;
- CODE int (*pre_parse)(int fd, FAR uint32_t *samplerate,
- FAR uint8_t *chans, FAR uint8_t *bps);
- CODE int (*fill_data)(int fd, FAR struct ap_buffer_s *apb);
+ CODE int (*pre_parse)(FAR struct nxplayer_s *pplayer, int fd,
Review Comment:
why need change the prototype? if the change is really needed, please split
the common change to the separated patch, and wave decoder in one and only one
patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
