imeghar2408-max commented on code in PR #3840:
URL: https://github.com/apache/nuttx-apps/pull/3840#discussion_r4287538392
##########
include/system/nxplayer.h:
##########
@@ -40,12 +41,17 @@
* Public Type Declarations
****************************************************************************/
+struct nxplayer_s;
+
struct nxplayer_dec_ops_s
{
int format;
- CODE int (*pre_parse)(int fd, FAR uint32_t *samplerate,
- FAR uint8_t *chans, FAR uint8_t *bps);
- CODE int (*fill_data)(int fd, FAR struct ap_buffer_s *apb);
+ CODE int (*pre_parse)(FAR struct nxplayer_s *pplayer, int fd,
Review Comment:
The prototype change is needed to pass the player context to decoder
callbacks and allow `pre_parse` to return the selected subformat. The WAV
decoder needs this to maintain per-player parsing state and select the
appropriate PCM subformat.
I'll separate the generic callback-interface change into its own commit,
using adapters to preserve the existing MP3/SBC and common PCM behavior. All
WAV-specific decoding and integration will be contained in one separate commit.
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
