xiaoxiang781216 commented on code in PR #5985: URL: https://github.com/apache/incubator-nuttx/pull/5985#discussion_r844938949
########## arch/risc-v/src/common/riscv_macros.S: ########## @@ -128,3 +133,22 @@ REGLOAD x31, REG_X31(\out) /* t6 */ .endm + +#if CONFIG_ARCH_INTERRUPTSTACK > 15 +.macro setintstack tmp0, tmp1 +#ifndef CONFIG_ARCH_USE_SMODE +#if CONFIG_SMP_NCPUS > 1 + csrr \tmp0, mhartid Review Comment: it's fine to put riscv_percpu.c in the common place, because user can simply ignore it by excluding it from compiling, but it's hard to replace setintstack if it define in riscv_macros.S, that's why I suggest riscv is better to follow other arch not define setintstack in the common place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
