pussuw commented on code in PR #5985:
URL: https://github.com/apache/incubator-nuttx/pull/5985#discussion_r844941552


##########
arch/risc-v/src/common/riscv_macros.S:
##########
@@ -128,3 +133,22 @@
   REGLOAD    x31, REG_X31(\out)  /* t6 */
 
 .endm
+
+#if CONFIG_ARCH_INTERRUPTSTACK > 15
+.macro  setintstack tmp0, tmp1
+#ifndef CONFIG_ARCH_USE_SMODE
+#if CONFIG_SMP_NCPUS > 1
+  csrr    \tmp0, mhartid

Review Comment:
   I agree it should be in the chip specific files, but no risc-v target 
implements setintstack. This basically like how it was before.
   
   Do you think I should add this code to every target or leave it like this 
for now ? Because if I implement this for mpfs only all other targets that use 
IRQ stack (every risc-v target in fact) will break ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to