mcvsubbu commented on a change in pull request #3675: Sslbranch
URL: https://github.com/apache/incubator-pinot/pull/3675#discussion_r288693041
##########
File path:
pinot-controller/src/main/java/com/linkedin/pinot/controller/ControllerConf.java
##########
@@ -200,12 +207,64 @@ public String getQueryConsoleWebappPath() {
return
ControllerConf.class.getClassLoader().getResource("webapp").toExternalForm();
}
- public void setQueryConsoleUseHttps(boolean useHttps) {
- setProperty(CONSOLE_WEBAPP_USE_HTTPS, useHttps);
+ public void setUseHttp(boolean useHTTP) {
+ setProperty(USE_HTTP, useHTTP);
}
- public boolean getQueryConsoleUseHttps() {
- return containsKey(CONSOLE_WEBAPP_USE_HTTPS) &&
getBoolean(CONSOLE_WEBAPP_USE_HTTPS);
+ public boolean getUseHttp() {
+ if (!containsKey(USE_HTTP)) {
+ return true;
+ } else {
+ return (boolean) getBoolean(USE_HTTP);
+ }
+ }
+
+ public void setUseHttps(boolean useHttps) {
+ setProperty(USE_HTTPS, useHttps);
+ }
+
+ public boolean getUseHttps() {
+ return containsKey(USE_HTTPS) && getBoolean(USE_HTTPS);
+ }
+
+ public void setKeyStoreFile(String keyStoreFile) {
+ setProperty(KEYSTORE_FILE, keyStoreFile);
+ }
+
+ public String getBrokerLoadbalancerAddress() {
Review comment:
There can be multiple brokers in the cluster, each serving some subset of
the tables. Not sure what the admin is supposed to set for the broker load
balancer here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
