mcvsubbu commented on a change in pull request #3675: Sslbranch
URL: https://github.com/apache/incubator-pinot/pull/3675#discussion_r288693600
##########
File path:
pinot-controller/src/main/java/com/linkedin/pinot/controller/api/resources/PqlQueryResource.java
##########
@@ -108,32 +109,39 @@ public String getQueryResponse(String pqlQuery, String
traceEnabled, HttpHeaders
}
String tableName =
TableNameBuilder.extractRawTableName(brokerRequest.getQuerySource().getTableName());
- // Validate data access
- AccessControl accessControl = _accessControlFactory.create();
- if (!accessControl.hasDataAccess(httpHeaders, tableName)) {
- return QueryException.ACCESS_DENIED_ERROR.toString();
- }
+ String brokerLBurl =
_pinotHelixResourceManager.getBrokerLoadBalancerAddress();
Review comment:
We should get the list of broker instances for the table from pinot helix
resource manager, and then use https on them if configured to do so. So,
perhaps that calls for another config to use https when querying brokers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
