mcvsubbu commented on a change in pull request #3675: Sslbranch
URL: https://github.com/apache/incubator-pinot/pull/3675#discussion_r288688917
##########
File path:
pinot-controller/src/main/java/com/linkedin/pinot/controller/ControllerStarter.java
##########
@@ -97,7 +98,24 @@
public ControllerStarter(ControllerConf conf) {
_config = conf;
- _adminApp = new
ControllerAdminApiApplication(_config.getQueryConsoleWebappPath(),
_config.getQueryConsoleUseHttps());
+
+ if (_config.getUseHttps()) {
+ LOGGER.info("Initializing https server");
+ _encryptedAdminApp = new
ControllerAdminApiApplication(_config.getQueryConsoleWebappPath(), true);
+ _encryptedAdminApp.setHttpsConfigs(_config.getKeyStoreFile(),
_config.getKeyStorePassword(),
+ _config.getTrustStoreFile(), _config.getTrustStorePassword());
+ }
+ else {
+ _encryptedAdminApp = null;
+ }
+
+ if (_config.getUseHttp()) {
+ LOGGER.info("Initializing http server");
+ _adminApp = new
ControllerAdminApiApplication(_config.getQueryConsoleWebappPath(), false);
+ }
+ else {
Review comment:
coding conv
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
