mcvsubbu commented on a change in pull request #3675: Sslbranch
URL: https://github.com/apache/incubator-pinot/pull/3675#discussion_r288689425
##########
File path:
pinot-controller/src/main/java/com/linkedin/pinot/controller/ControllerStarter.java
##########
@@ -244,15 +264,39 @@ protected void configure() {
bind(_controllerMetrics).to(ControllerMetrics.class);
bind(accessControlFactory).to(AccessControlFactory.class);
bind(metadataEventNotifierFactory).to(MetadataEventNotifierFactory.class);
- }
- });
-
- _adminApp.start(jerseyPort);
- LOGGER.info("Started Jersey API on port {}", jerseyPort);
- LOGGER.info("Pinot controller ready and listening on port {} for API
requests", _config.getControllerPort());
- LOGGER.info("Controller services available at http://{}:{}/";,
_config.getControllerHost(),
- _config.getControllerPort());
-
+ }
+ });
+ _adminApp.start(httpJerseyPort);
+ LOGGER.info("Started Jersey API for http server on port {}",
httpJerseyPort);
+ LOGGER.info("Pinot controller ready and listening on port {} for API
requests", httpJerseyPort);
+ }
+ if (_encryptedAdminApp != null) {
+ _encryptedAdminApp.registerBinder(new AbstractBinder() {
+ @Override
+ protected void configure() {
+ bind(_config).to(ControllerConf.class);
+ bind(_helixResourceManager).to(PinotHelixResourceManager.class);
+
bind(_helixTaskResourceManager).to(PinotHelixTaskResourceManager.class);
+ bind(_taskManager).to(PinotTaskManager.class);
+ bind(connectionManager).to(HttpConnectionManager.class);
+ bind(_executorService).to(Executor.class);
+ bind(_controllerMetrics).to(ControllerMetrics.class);
+ bind(accessControlFactory).to(AccessControlFactory.class);
+
bind(metadataEventNotifierFactory).to(MetadataEventNotifierFactory.class);
+ }
+ });
+ _encryptedAdminApp.start(httpsJerseyPort);
+ LOGGER.info("Started Jersey API for https server on port {}",
httpsJerseyPort);
+ LOGGER.info("Pinot controller ready and listening on port {} for API
requests", httpsJerseyPort);
Review comment:
s/port/https port/
thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
