mcvsubbu commented on a change in pull request #3675: Sslbranch
URL: https://github.com/apache/incubator-pinot/pull/3675#discussion_r288681543
##########
File path:
pinot-broker/src/main/java/com/linkedin/pinot/broker/broker/BrokerAdminApiApplication.java
##########
@@ -70,7 +98,12 @@ private void setupSwagger() {
beanConfig.setDescription("APIs for accessing Pinot broker information");
beanConfig.setContact("https://github.com/linkedin/pinot";);
beanConfig.setVersion("1.0");
- beanConfig.setSchemes(new String[]{"http"});
+ if (_useHTTPS) {
+ beanConfig.setSchemes(new String[]{"https"});
+ }
Review comment:
please move up the else to this line, as per coding conventions. See
https://pinot.readthedocs.io/en/latest/dev_guide.html on how to set up your dev
guide so that coding conventions are automatic. thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
